[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20210706011150.670544-1-gushengxian507419@gmail.com>
Date: Mon, 5 Jul 2021 18:11:50 -0700
From: gushengxian <gushengxian507419@...il.com>
To: ast@...nel.org, daniel@...earbox.net, andrii@...nel.org
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org,
linux-kernel@...r.kernel.org, gushengxian <gushengxian@...ong.com>
Subject: [PATCH v2] tools: bpftool: close va_list 'ap' by va_end()
From: gushengxian <gushengxian@...ong.com>
va_list 'ap' was opened but not closed by va_end(). It should be
closed by va_end() before return.
According to suggestion of Daniel Borkmann <daniel@...earbox.net>.
Signed-off-by: gushengxian <gushengxian@...ong.com>
---
tools/bpf/bpftool/jit_disasm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c
index e7e7eee9f172..24734f2249d6 100644
--- a/tools/bpf/bpftool/jit_disasm.c
+++ b/tools/bpf/bpftool/jit_disasm.c
@@ -43,11 +43,13 @@ static int fprintf_json(void *out, const char *fmt, ...)
{
va_list ap;
char *s;
+ int err;
va_start(ap, fmt);
- if (vasprintf(&s, fmt, ap) < 0)
- return -1;
+ err = vasprintf(&s, fmt, ap);
va_end(ap);
+ if (err < 0)
+ return -1;
if (!oper_count) {
int i;
--
2.25.1
Powered by blists - more mailing lists