| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Jul 2021 09:11:24 -0600
From: Mathieu Poirier <mathieu.poirier@...aro.org>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Russell King <linux@...linux.org.uk>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
Helge Deller <deller@....de>,
Geoff Levand <geoff@...radead.org>,
Michael Ellerman <mpe@...erman.id.au>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <lenb@...nel.org>,
William Breathitt Gray <vilhelm.gray@...il.com>,
Rafał Miłecki <zajec5@...il.com>,
Maxime Ripard <mripard@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Alison Schofield <alison.schofield@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Ira Weiny <ira.weiny@...el.com>,
Ben Widawsky <ben.widawsky@...el.com>,
Dan Williams <dan.j.williams@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
Vinod Koul <vkoul@...nel.org>,
Stefan Richter <stefanr@...6.in-berlin.de>,
Sudeep Holla <sudeep.holla@....com>,
Cristian Marussi <cristian.marussi@....com>,
Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
Moritz Fischer <mdf@...nel.org>,
Jiri Kosina <jikos@...nel.org>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
"K. Y. Srinivasan" <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Stephen Hemminger <sthemmin@...rosoft.com>,
Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Wolfram Sang <wsa@...nel.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
Jens Taprogge <jens.taprogge@...rogge.org>,
Johannes Thumshirn <morbidrsa@...il.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Maxim Levitsky <maximlevitsky@...il.com>,
Alex Dubov <oakad@...oo.com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Lee Jones <lee.jones@...aro.org>,
Tomas Winkler <tomas.winkler@...el.com>,
Arnd Bergmann <arnd@...db.de>,
Jakub Kicinski <kuba@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Jon Mason <jdmason@...zu.us>, Allen Hubbe <allenbh@...il.com>,
Kishon Vijay Abraham I <kishon@...com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Krzysztof Wilczyński <kw@...ux.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Dominik Brodowski <linux@...inikbrodowski.net>,
Maximilian Luz <luzmaximilian@...il.com>,
Hans de Goede <hdegoede@...hat.com>,
Mark Gross <mgross@...ux.intel.com>,
Matt Porter <mporter@...nel.crashing.org>,
Alexandre Bounine <alex.bou9@...il.com>,
Ohad Ben-Cohen <ohad@...ery.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Thorsten Scherer <t.scherer@...elmann.de>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Andy Gross <agross@...nel.org>,
Mark Brown <broonie@...nel.org>,
Stephen Boyd <sboyd@...nel.org>, Michael Buesch <m@...s.ch>,
Sven Van Asbroeck <TheSven73@...il.com>,
Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
Andreas Noever <andreas.noever@...il.com>,
Michael Jamet <michael.jamet@...el.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Yehezkel Bernat <YehezkelShB@...il.com>,
Rob Herring <robh@...nel.org>,
Jiri Slaby <jirislaby@...nel.org>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Kirti Wankhede <kwankhede@...dia.com>,
Alex Williamson <alex.williamson@...hat.com>,
Cornelia Huck <cohuck@...hat.com>,
Martyn Welch <martyn@...chs.me.uk>,
Manohar Vanga <manohar.vanga@...il.com>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Juergen Gross <jgross@...e.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Johannes Berg <johannes@...solutions.net>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Marc Zyngier <maz@...nel.org>,
Tyrel Datwyler <tyreld@...ux.ibm.com>,
Vladimir Zapolskiy <vz@...ia.com>,
Samuel Holland <samuel@...lland.org>,
Qinglang Miao <miaoqinglang@...wei.com>,
Alexey Kardashevskiy <aik@...abs.ru>,
Kai-Heng Feng <kai.heng.feng@...onical.com>,
Joey Pabalan <jpabalanb@...il.com>,
Pali Rohár <pali@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Frank Li <lznuaa@...il.com>,
Mike Christie <michael.christie@...cle.com>,
Bodo Stroesser <bostroesser@...il.com>,
Hannes Reinecke <hare@...e.de>,
David Woodhouse <dwmw@...zon.co.uk>,
SeongJae Park <sjpark@...zon.de>,
Julien Grall <jgrall@...zon.com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-acpi@...r.kernel.org,
linux-wireless@...r.kernel.org, linux-sunxi@...ts.linux.dev,
linux-cxl@...r.kernel.org, nvdimm@...ts.linux.dev,
dmaengine@...r.kernel.org, linux1394-devel@...ts.sourceforge.net,
linux-fpga@...r.kernel.org, linux-input@...r.kernel.org,
linux-hyperv@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-i3c@...ts.infradead.org,
industrypack-devel@...ts.sourceforge.net,
linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
netdev@...r.kernel.org, linux-ntb@...glegroups.com,
linux-pci@...r.kernel.org, platform-driver-x86@...r.kernel.org,
linux-remoteproc <linux-remoteproc@...r.kernel.org>,
linux-scsi@...r.kernel.org, alsa-devel@...a-project.org,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
linux-spi@...r.kernel.org, linux-staging@...ts.linux.dev,
greybus-dev@...ts.linaro.org, target-devel@...r.kernel.org,
linux-usb@...r.kernel.org, linux-serial@...r.kernel.org,
virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
xen-devel@...ts.xenproject.org
Subject: Re: [PATCH] bus: Make remove callback return void
On Tue, 6 Jul 2021 at 03:56, Uwe Kleine-König
<u.kleine-koenig@...gutronix.de> wrote:
>
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
>
> this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
> return void" that is not yet applied, see
> https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutronix.de.
>
> I tested it using allmodconfig on amd64 and arm, but I wouldn't be
> surprised if I still missed to convert a driver. So it would be great to
> get this into next early after the merge window closes.
>
> I send this mail to all people that get_maintainer.pl emits for this
> patch. I wonder how many recipents will refuse this mail because of the
> long Cc: list :-)
>
> Best regards
> Uwe
>
> arch/arm/common/locomo.c | 3 +--
> arch/arm/common/sa1111.c | 4 +---
> arch/arm/mach-rpc/ecard.c | 4 +---
> arch/mips/sgi-ip22/ip22-gio.c | 3 +--
> arch/parisc/kernel/drivers.c | 5 ++---
> arch/powerpc/platforms/ps3/system-bus.c | 3 +--
> arch/powerpc/platforms/pseries/ibmebus.c | 3 +--
> arch/powerpc/platforms/pseries/vio.c | 3 +--
> drivers/acpi/bus.c | 3 +--
> drivers/amba/bus.c | 4 +---
> drivers/base/auxiliary.c | 4 +---
> drivers/base/isa.c | 4 +---
> drivers/base/platform.c | 4 +---
> drivers/bcma/main.c | 6 ++----
> drivers/bus/sunxi-rsb.c | 4 +---
> drivers/cxl/core.c | 3 +--
> drivers/dax/bus.c | 4 +---
> drivers/dma/idxd/sysfs.c | 4 +---
> drivers/firewire/core-device.c | 4 +---
> drivers/firmware/arm_scmi/bus.c | 4 +---
> drivers/firmware/google/coreboot_table.c | 4 +---
> drivers/fpga/dfl.c | 4 +---
> drivers/hid/hid-core.c | 4 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
> drivers/hv/vmbus_drv.c | 5 +----
> drivers/hwtracing/intel_th/core.c | 4 +---
> drivers/i2c/i2c-core-base.c | 5 +----
> drivers/i3c/master.c | 4 +---
> drivers/input/gameport/gameport.c | 3 +--
> drivers/input/serio/serio.c | 3 +--
> drivers/ipack/ipack.c | 4 +---
> drivers/macintosh/macio_asic.c | 4 +---
> drivers/mcb/mcb-core.c | 4 +---
> drivers/media/pci/bt8xx/bttv-gpio.c | 3 +--
> drivers/memstick/core/memstick.c | 3 +--
> drivers/mfd/mcp-core.c | 3 +--
> drivers/misc/mei/bus.c | 4 +---
> drivers/misc/tifm_core.c | 3 +--
> drivers/mmc/core/bus.c | 4 +---
> drivers/mmc/core/sdio_bus.c | 4 +---
> drivers/net/netdevsim/bus.c | 3 +--
> drivers/ntb/core.c | 4 +---
> drivers/ntb/ntb_transport.c | 4 +---
> drivers/nvdimm/bus.c | 3 +--
> drivers/pci/endpoint/pci-epf-core.c | 4 +---
> drivers/pci/pci-driver.c | 3 +--
> drivers/pcmcia/ds.c | 4 +---
> drivers/platform/surface/aggregator/bus.c | 4 +---
> drivers/platform/x86/wmi.c | 4 +---
> drivers/pnp/driver.c | 3 +--
> drivers/rapidio/rio-driver.c | 4 +---
> drivers/rpmsg/rpmsg_core.c | 4 +---
Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>
Powered by blists - more mailing lists