netdev - Re: [PATCHv4 iproute2] ip route: ignore ENOENT during save if RT_TABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210706184415.baf59983a9cb5de56050389c@virtuozzo.com>
Date:   Tue, 6 Jul 2021 18:44:15 +0300
From:   Alexander Mikhalitsyn <alexander.mikhalitsyn@...tuozzo.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>,
        Andrei Vagin <avagin@...il.com>,
        Alexander Mikhalitsyn <alexander@...alicyn.com>
Subject: Re: [PATCHv4 iproute2] ip route: ignore ENOENT during save if
 RT_TABLE_MAIN is being dumped

On Tue, 6 Jul 2021 08:34:07 -0700
Stephen Hemminger <stephen@...workplumber.org> wrote:

> On Tue, 29 Jun 2021 18:51:15 +0300
> Alexander Mikhalitsyn <alexander.mikhalitsyn@...tuozzo.com> wrote:
> 
> > +	const struct rtnl_dump_filter_arg a[2] = {
> > +		{ .filter = filter, .arg1 = arg1,
> > +		  .errhndlr = errhndlr, .arg2 = arg2, .nc_flags = nc_flags, },
> > +		{ .filter = NULL,   .arg1 = NULL,
> > +		  .errhndlr = NULL, .arg2 = NULL, .nc_flags = 0, },
> >  	};
> 
> I am OK with this as is. But you don't need to add initializers for fields
> that are 0/NULL (at least in C).

Sure, I've made such explicit initializations just because in original
rtnl_dump_filter_nc() we already have them.

Do I need to resend with fixed initializations? ;)

> 
> So could be:
> 	const struct rtnl_dump_filter_arg a[] = {
> 		{ .filter = filter, .arg1 = arg1,
> 		  .errhndlr = errhndlr, .arg2 = arg2, .nc_flags = nc_flags, },
> 		{  },
>  	};

Thanks,
Alex