netdev - Re: [PATCH v2 4/4] bus: Make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YOTMp88HfFiy6+RM@shinobu>
Date:   Wed, 7 Jul 2021 06:37:39 +0900
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-acpi@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-sunxi@...ts.linux.dev, linux-cxl@...r.kernel.org,
        nvdimm@...ts.linux.dev, dmaengine@...r.kernel.org,
        linux1394-devel@...ts.sourceforge.net, linux-fpga@...r.kernel.org,
        linux-input@...r.kernel.org, linux-hyperv@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-i3c@...ts.infradead.org,
        industrypack-devel@...ts.sourceforge.net,
        linux-media@...r.kernel.org, linux-mmc@...r.kernel.org,
        netdev@...r.kernel.org, linux-ntb@...glegroups.com,
        linux-pci@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-scsi@...r.kernel.org,
        alsa-devel@...a-project.org, linux-arm-msm@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-staging@...ts.linux.dev,
        greybus-dev@...ts.linaro.org, target-devel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-serial@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v2 4/4] bus: Make remove callback return void

On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
> 
> Acked-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk> (For ARM, Amba and related parts)
> Acked-by: Mark Brown <broonie@...nel.org>
> Acked-by: Chen-Yu Tsai <wens@...e.org> (for drivers/bus/sunxi-rsb.c)
> Acked-by: Pali Rohár <pali@...nel.org>
> Acked-by: Mauro Carvalho Chehab <mchehab@...nel.org> (for drivers/media)
> Acked-by: Hans de Goede <hdegoede@...hat.com> (For drivers/platform)
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Acked-By: Vinod Koul <vkoul@...nel.org>
> Acked-by: Juergen Gross <jgross@...e.com> (For Xen)
> Acked-by: Lee Jones <lee.jones@...aro.org> (For drivers/mfd)
> Acked-by: Johannes Thumshirn <jth@...nel.org> (For drivers/mcb)
> Acked-by: Johan Hovold <johan@...nel.org>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org> (For drivers/slimbus)
> Acked-by: Kirti Wankhede <kwankhede@...dia.com> (For drivers/vfio)
> Acked-by: Maximilian Luz <luzmaximilian@...il.com>
> Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com> (For ulpi and typec)
> Acked-by: Samuel Iglesias Gonsálvez <siglesias@...lia.com> (For ipack)
> Reviewed-by: Tom Rix <trix@...hat.com> (For fpga)
> Acked-by: Geoff Levand <geoff@...radead.org> (For ps3)
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

>  drivers/base/isa.c                        | 4 +---

Acked-by: William Breathitt Gray <vilhelm.gray@...il.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)