netdev - Re: [PATCH] tools/runqslower: Change state to _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW4H20yNVuJW9RT01V2Qti8Yhxo=K432KBKoexe4boMhnw@mail.gmail.com>
Date:   Tue, 6 Jul 2021 15:57:33 -0700
From:   Song Liu <song@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] tools/runqslower: Change state to __state

On Tue, Jul 6, 2021 at 3:53 PM Song Liu <song@...nel.org> wrote:
>
> On Tue, Jul 6, 2021 at 1:40 PM Jiri Olsa <jolsa@...hat.com> wrote:
> >
> > The task_struct state got renamed to __state, causing
> > compile fail:
> >
> >   runqslower.bpf.c:77:12: error: no member named 'state' in 'struct task_struct'
> >         if (prev->state == TASK_RUNNING)
> >
> > As this is tracing prog, I think we don't need to use
> > READ_ONCE to access __state.
> >
> > Fixes: 2f064a59a11f ("sched: Change task_struct::state")
> > Signed-off-by: Jiri Olsa <jolsa@...nel.org>
>
> Acked-by: Song Liu <songliubraving@...com>

Just realized there is another thread fixing the same error.

Thanks,
Song