[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <PH0PR04MB7416BD31D84E2F63346A6F709B1B9@PH0PR04MB7416.namprd04.prod.outlook.com>
Date: Tue, 6 Jul 2021 10:47:28 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Lee Jones <lee.jones@...aro.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Russell King <linux@...linux.org.uk>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
Helge Deller <deller@....de>,
Geoff Levand <geoff@...radead.org>,
Michael Ellerman <mpe@...erman.id.au>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
"linux-sunxi@...ts.linux.dev" <linux-sunxi@...ts.linux.dev>,
"linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>,
"nvdimm@...ts.linux.dev" <nvdimm@...ts.linux.dev>,
"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
"linux1394-devel@...ts.sourceforge.net"
<linux1394-devel@...ts.sourceforge.net>,
"linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
"industrypack-devel@...ts.sourceforge.net"
<industrypack-devel@...ts.sourceforge.net>,
"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-ntb@...glegroups.com" <linux-ntb@...glegroups.com>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"platform-driver-x86@...r.kernel.org"
<platform-driver-x86@...r.kernel.org>,
"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
"linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
"greybus-dev@...ts.linaro.org" <greybus-dev@...ts.linaro.org>,
"target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
"virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH] bus: Make remove callback return void
On 06/07/2021 12:36, Lee Jones wrote:
> On Tue, 06 Jul 2021, Uwe Kleine-König wrote:
>
>> The driver core ignores the return value of this callback because there
>> is only little it can do when a device disappears.
>>
>> This is the final bit of a long lasting cleanup quest where several
>> buses were converted to also return void from their remove callback.
>> Additionally some resource leaks were fixed that were caused by drivers
>> returning an error code in the expectation that the driver won't go
>> away.
>>
>> With struct bus_type::remove returning void it's prevented that newly
>> implemented buses return an ignored error code and so don't anticipate
>> wrong expectations for driver authors.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
>> ---
>> Hello,
>>
>> this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
>> return void" that is not yet applied, see
>> https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koenig@pengutronix.de.
>>
>> I tested it using allmodconfig on amd64 and arm, but I wouldn't be
>> surprised if I still missed to convert a driver. So it would be great to
>> get this into next early after the merge window closes.
>>
>> I send this mail to all people that get_maintainer.pl emits for this
>> patch. I wonder how many recipents will refuse this mail because of the
>> long Cc: list :-)
>>
>> Best regards
>> Uwe
>>
>> arch/arm/common/locomo.c | 3 +--
>> arch/arm/common/sa1111.c | 4 +---
>> arch/arm/mach-rpc/ecard.c | 4 +---
>> arch/mips/sgi-ip22/ip22-gio.c | 3 +--
>> arch/parisc/kernel/drivers.c | 5 ++---
>> arch/powerpc/platforms/ps3/system-bus.c | 3 +--
>> arch/powerpc/platforms/pseries/ibmebus.c | 3 +--
>> arch/powerpc/platforms/pseries/vio.c | 3 +--
>> drivers/acpi/bus.c | 3 +--
>> drivers/amba/bus.c | 4 +---
>> drivers/base/auxiliary.c | 4 +---
>> drivers/base/isa.c | 4 +---
>> drivers/base/platform.c | 4 +---
>> drivers/bcma/main.c | 6 ++----
>> drivers/bus/sunxi-rsb.c | 4 +---
>> drivers/cxl/core.c | 3 +--
>> drivers/dax/bus.c | 4 +---
>> drivers/dma/idxd/sysfs.c | 4 +---
>> drivers/firewire/core-device.c | 4 +---
>> drivers/firmware/arm_scmi/bus.c | 4 +---
>> drivers/firmware/google/coreboot_table.c | 4 +---
>> drivers/fpga/dfl.c | 4 +---
>> drivers/hid/hid-core.c | 4 +---
>> drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
>> drivers/hv/vmbus_drv.c | 5 +----
>> drivers/hwtracing/intel_th/core.c | 4 +---
>> drivers/i2c/i2c-core-base.c | 5 +----
>> drivers/i3c/master.c | 4 +---
>> drivers/input/gameport/gameport.c | 3 +--
>> drivers/input/serio/serio.c | 3 +--
>> drivers/ipack/ipack.c | 4 +---
>> drivers/macintosh/macio_asic.c | 4 +---
>> drivers/mcb/mcb-core.c | 4 +---
Acked-by: Johannes Thumshirn <jth@...nel.org> # for drivers/mcb
Powered by blists - more mailing lists