netdev - Re: [PATCH] ieee802154: hwsim: fix GPF in hwsim_new_edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Jul 2021 19:32:22 -0400
From:   Alexander Aring <alex.aring@...il.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Stefan Schmidt <stefan@...enfreihafen.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexander Aring <aring@...atatu.com>,
        linux-wpan - ML <linux-wpan@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ieee802154: hwsim: fix GPF in hwsim_new_edge_nl

Hi,

On Wed, 7 Jul 2021 at 19:15, Dongliang Mu <mudongliangabcd@...il.com> wrote:
>
> On Thu, Jul 8, 2021 at 2:55 AM Alexander Aring <alex.aring@...il.com> wrote:
> >
> > Hi,
> >
> > On Wed, 7 Jul 2021 at 12:11, Dongliang Mu <mudongliangabcd@...il.com> wrote:
> > >
> > > On Wed, Jul 7, 2021 at 11:56 PM Dongliang Mu <mudongliangabcd@...il.com> wrote:
> > > >
> > > > Both MAC802154_HWSIM_ATTR_RADIO_ID and MAC802154_HWSIM_ATTR_RADIO_EDGE
> > > > must be present to fix GPF.
> > >
> > > I double-check the whole file, and there is only one similar issue
> > > left in Line 421.
> > >
> >
> > What about "hwsim_del_edge_nl()" line 483, I think it has the same issue?
>
> Eric already submitted a patch [1] to fix this function and the patch
> is already merged in the mainline.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0303b30375dff5351a79cc2c3c87dfa4fda29bed

ah, yes. Thanks.

- Alex