netdev - Re: [PATCH net-next v2] drivers: net: Follow the indentation coding standard on printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccf9f07a72c911652d24ceb6c6e925f834f1d338.camel@perches.com>
Date:   Thu, 08 Jul 2021 10:38:26 -0700
From:   Joe Perches <joe@...ches.com>
To:     Carlos Bilbao <bilbao@...edu>, davem@...emloft.net
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, andrew@...n.ch,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH net-next v2] drivers: net: Follow the indentation coding
 standard on printks

On Thu, 2021-07-08 at 13:33 -0400, Carlos Bilbao wrote:
> Fix indentation of printks that start at the beginning of the line. Change this 
> for the right number of space characters, or tabs if the file uses them. 

You are touching 2 different drivers and this should really be
2 separate patches.

> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c.rej b/drivers/net/ethernet/dec/tulip/de4x5.c.rej
[]
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c.rej
> @@ -0,0 +1,11 @@
> +--- drivers/net/ethernet/dec/tulip/de4x5.c
> ++++ drivers/net/ethernet/dec/tulip/de4x5.c
> +@@ -3169,7 +3169,7 @@ dc2114x_autoconf(struct net_device *dev)
> + 
> +     default:
> +        lp->tcount++;
> +-printk("Huh?: media:%02x\n", lp->media);
> ++       printk("Huh?: media:%02x\n", lp->media);
> +        lp->media = INIT;
> +        break;
> +     }

This is an interdiff that should not be part of this change.