netdev - Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on unlikely error case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60e76268e64fc_653a42085b@john-XPS-13-9370.notmuch>
Date:   Thu, 08 Jul 2021 13:39:04 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf v3 1/2] bpf, sockmap: fix potential memory leak on
 unlikely error case

Cong Wang wrote:
> On Tue, Jul 6, 2021 at 9:31 AM John Fastabend <john.fastabend@...il.com> wrote:
> >
> > If skb_linearize is needed and fails we could leak a msg on the error
> > handling. To fix ensure we kfree the msg block before returning error.
> > Found during code review.
> 
> sk_psock_skb_ingress_self() also needs the same fix, right?

Yep.

> Other than this, it looks good to me.

I'll do another spin to get the other one as well. Mind as well
fix both cases at once.

> 
> Thanks.