netdev - Re: [PATCH bpf v2 2/2] bpf: selftest to verify mixing bpf2bpf calls and tailcalls with insn patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Jul 2021 13:42:25 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf v2 2/2] bpf: selftest to verify mixing bpf2bpf calls
 and tailcalls with insn patch

Alexei Starovoitov wrote:
> On Wed, Jul 7, 2021 at 3:39 PM John Fastabend <john.fastabend@...il.com> wrote:
> >
> > -static volatile int count;
> > +int count = 0;
> > +int noise = 0;
> > +
> > +__always_inline int subprog_noise(void)
> > +{
> > +       __u32 key = 0;
> > +
> > +       bpf_printk("hello noisy subprog %d\n", key);
> > +       bpf_map_lookup_elem(&nop_table, &key);
> > +       return 0;
> > +}
> 
> This selftest patch I had to apply manually due to conflicts.
> I've also removed the noisy printk before pushing.

Thanks! I had the printk there to verify the code was actually
being run, but forgot to remove it before submitting.

> I verified that I saw the spam before removing it.

Great.

> The patch 1 looks great. Thanks a lot for the fix.