netdev - Re: [PATCH bpf-next v8 3/4] bpf: support specifying ingress via xdp_md context in BPF_PROG_TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb6374ff-a649-c80a-a67b-ded0f3542011@fb.com>
Date:   Wed, 7 Jul 2021 19:33:54 -0700
From:   Yonghong Song <yhs@...com>
To:     Zvi Effron <zeffron@...tgames.com>, <bpf@...r.kernel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Martin KaFai Lau <kafai@...com>, <netdev@...r.kernel.org>,
        KP Singh <kpsingh@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Song Liu <songliubraving@...com>,
        Jakub Kicinski <kuba@...nel.org>,
        Cody Haas <chaas@...tgames.com>,
        Lisa Watanabe <lwatanabe@...tgames.com>
Subject: Re: [PATCH bpf-next v8 3/4] bpf: support specifying ingress via
 xdp_md context in BPF_PROG_TEST_RUN



On 7/7/21 3:16 PM, Zvi Effron wrote:
> Support specifying the ingress_ifindex and rx_queue_index of xdp_md
> contexts for BPF_PROG_TEST_RUN.
> 
> The intended use case is to allow testing XDP programs that make decisions
> based on the ingress interface or RX queue.
> 
> If ingress_ifindex is specified, look up the device by the provided index
> in the current namespace and use its xdp_rxq for the xdp_buff. If the
> rx_queue_index is out of range, or is non-zero when the ingress_ifindex is
> 0, return -EINVAL.
> 
> Co-developed-by: Cody Haas <chaas@...tgames.com>
> Signed-off-by: Cody Haas <chaas@...tgames.com>
> Co-developed-by: Lisa Watanabe <lwatanabe@...tgames.com>
> Signed-off-by: Lisa Watanabe <lwatanabe@...tgames.com>
> Signed-off-by: Zvi Effron <zeffron@...tgames.com>

I double checked reference counting for `device` and it seems correct
to me, so
Acked-by: Yonghong Song <yhs@...com>