netdev - Re: [PATCH net 1/1] tc-testing: Update police test cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Jul 2021 15:11:56 +0300
From:   Roi Dayan <roid@...dia.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>, <netdev@...r.kernel.org>
CC:     David Ahern <dsahern@...il.com>,
        Hangbin Liu <liuhangbin@...il.com>,
        "Paul Blakey" <paulb@...dia.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Roman Mashak <mrv@...atatu.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        "Stephen Hemminger" <stephen@...workplumber.org>
Subject: Re: [PATCH net 1/1] tc-testing: Update police test cases



On 2021-07-08 2:17 PM, Jamal Hadi Salim wrote:
> On 2021-07-08 4:00 a.m., Roi Dayan wrote:
>> Update to match fixed output.
>>
>> Signed-off-by: Roi Dayan <roid@...dia.com>
>> ---
>>
>> Notes:
>>      Hi,
>>      This is related to commit that was merged
>>      55abdcf20a57 police: Add support for json output
>>      and also submitted another small fix commit titled
>>      "police: Small corrections for the output"
>>      Thanks,
>>      Roi
>>
>>   .../tc-testing/tc-tests/actions/police.json   | 62 +++++++++----------
>>   1 file changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git 
>> a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json 
>> b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>> index 8e45792703ed..c9623c7afbd1 100644
>> --- a/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>> +++ b/tools/testing/selftests/tc-testing/tc-tests/actions/police.json
>> @@ -17,7 +17,7 @@
>>           "cmdUnderTest": "$TC actions add action police rate 1kbit 
>> burst 10k index 1",
>>           "expExitCode": "0",
>>           "verifyCmd": "$TC actions ls action police",
>> -        "matchPattern": "action order [0-9]*:  police 0x1 rate 1Kbit 
>> burst 10Kb",
>> +        "matchPattern": "action order [0-9]*: police.*index 1 rate 
>> 1Kbit burst 10Kb",
>>           "matchCount": "1",
>>           "teardown": [
>>               "$TC actions flush action police"
> 
> Does the old output continue to work here?
> 
> cheers,
> jamal


no. old output doesn't have the string "index" and also output of index
is in hex.

it is possible to make the old version work by allowing without index
and looking for either the unsigned number or hex number/

but why do we need the old output to work? could use the "old" version
of the test.