netdev - Re: [PATCHv2] selftests: Use kselftest skip code for skipped tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f4e4c5a-9544-3339-0aef-1f0889e4a422@linuxfoundation.org>
Date:   Fri, 9 Jul 2021 11:53:49 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Po-Hsu Lin <po-hsu.lin@...onical.com>,
        linux-kselftest@...r.kernel.org
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        shuah <shuah@...nel.org>, ast@...nel.org,
        Petr Machata <petrm@...dia.com>, daniel@...earbox.net,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, hawk@...nel.org,
        nikolay@...dia.com, gnault@...hat.com, vladimir.oltean@....com,
        idosch@...dia.com, baowen.zheng@...igine.com, danieller@...dia.com,
        Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCHv2] selftests: Use kselftest skip code for skipped tests

On 7/7/21 10:18 PM, Po-Hsu Lin wrote:
> On Wed, May 26, 2021 at 4:54 PM Petr Machata <petrm@...dia.com> wrote:
>>
>>
>> Po-Hsu Lin <po-hsu.lin@...onical.com> writes:
>>
>>> There are several test cases still using exit 0 when they need to be
>>> skipped. Use kselftest framework skip code instead so it can help us
>>> to distinguish the proper return status.
>>>
>>> Criterion to filter out what should be fixed in selftests directory:
>>>    grep -r "exit 0" -B1 | grep -i skip
>>>
>>> This change might cause some false-positives if people are running
>>> these test scripts directly and only checking their return codes,
>>> which will change from 0 to 4. However I think the impact should be
>>> small as most of our scripts here are already using this skip code.
>>> And there will be no such issue if running them with the kselftest
>>> framework.
>>>
>>> V2: router_mpath_nh.sh and outer_mpath_nh_res.sh sources lib.sh,
>>> there is no need to assign ksft_skip value in these two.
>>>
>>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@...onical.com>
>>
>> I want to note that defining ksft_skip=4 in every test separately is the
>> current practice. I agree with Willem (in a parallel thread) that this
>> stuff should live in a library of its own, but there is none currently.
>> When there is, it looks like the conversion would be mechanical.
>>
>> Which is to say, IMHO this patch makes sense on its own as an
>> incremental improvement.
>>
>> Reviewed-by: Petr Machata <petrm@...dia.com>
> 
> Hello folks,
> any other comment on this patch? Or if I should break this down to
> smaller patches for different suites in kselftests?
> Thanks!
> PHLin
> 

Yes plase, break them into individual patches.

Breaking this into individual patches makes it easier to pull them
in and allows us handle dependencies better.

thanks,
-- Shuah