netdev - Re: [Patch net-next] net: use %px to print skb address in trace_netif_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210709.121852.1733023630353535689.davem@davemloft.net>
Date:   Fri, 09 Jul 2021 12:18:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, qitao.xu@...edance.com,
        cong.wang@...edance.com
Subject: Re: [Patch net-next] net: use %px to print skb address in
 trace_netif_receive_skb

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 9 Jul 2021 11:59:43 -0700

> On Fri, Jul 9, 2021 at 1:16 AM David Miller <davem@...emloft.net> wrote:
>>
>> From: Cong Wang <xiyou.wangcong@...il.com>
>> Date: Thu,  8 Jul 2021 22:17:08 -0700
>>
>> > From: Qitao Xu <qitao.xu@...edance.com>
>> >
>> > The print format of skb adress in tracepoint class net_dev_template
>> > is changed to %px from %p, because we want to use skb address
>> > as a quick way to identify a packet.
>> >
>> > Reviewed-by: Cong Wang <cong.wang@...edance.com>
>> > Signed-off-by: Qitao Xu <qitao.xu@...edance.com>
>>
>> Aren't we not supposed to leak kernel addresses to userspace?
> 
> Right, but trace ring buffer is only accessible to privileged users,
> so leaking it to root is not a problem.

Please explain this in your commit msgs and resubmit.

Thank you.