netdev - Re: [PATCH net] ptp: Relocate lookup cookie to correct block.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <691638583.174057.1625922797445@mail1.libero.it>
Date:   Sat, 10 Jul 2021 15:13:17 +0200 (CEST)
From:   dariobin@...ero.it
To:     Jonathan Lemon <jonathan.lemon@...il.com>, davem@...emloft.net,
        richardcochran@...il.com
Cc:     kernel-team@...com, netdev@...r.kernel.org
Subject: Re: [PATCH net] ptp: Relocate lookup cookie to correct block.

Hi Jonathan,
IMHO it is unfair that I am not the commit author of this patch.

Thanks and regards,
Dario

> Il 08/07/2021 20:04 Jonathan Lemon <jonathan.lemon@...il.com> ha scritto:
> 
>  
> An earlier commit set the pps_lookup cookie, but the line
> was somehow added to the wrong code block.  Correct this.
> 
> Fixes: 8602e40fc813 ("ptp: Set lookup cookie when creating a PTP PPS source.")
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>
> Signed-off-by: Dario Binacchi <dariobin@...ero.it>
> Acked-by: Richard Cochran <richardcochran@...il.com>
> ---
>  drivers/ptp/ptp_clock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index ce6d9fc85607..4dfc52e06704 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -232,7 +232,6 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>  			pr_err("failed to create ptp aux_worker %d\n", err);
>  			goto kworker_err;
>  		}
> -		ptp->pps_source->lookup_cookie = ptp;
>  	}
>  
>  	/* PTP virtual clock is being registered under physical clock */
> @@ -268,6 +267,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>  			pr_err("failed to register pps source\n");
>  			goto no_pps;
>  		}
> +		ptp->pps_source->lookup_cookie = ptp;
>  	}
>  
>  	/* Initialize a new device of our class in our clock structure. */
> -- 
> 2.30.2