netdev - Re: [PATCH net] net: phy: marvell10g: fix differentiation of 88X3310 from 88X3340

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Jul 2021 18:50:56 +0200
From:   Matteo Croce <mcroce@...ux.microsoft.com>
To:     Marek Behún <kabel@...nel.org>
Cc:     netdev@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net] net: phy: marvell10g: fix differentiation of 88X3310
 from 88X3340

On Sun, Jul 11, 2021 at 6:38 PM Marek Behún <kabel@...nel.org> wrote:
>
> It seems that we cannot differentiate 88X3310 from 88X3340 by simply
> looking at bit 3 of revision ID. This only works on revisions A0 and A1.
> On revision B0, this bit is always 1.
>
> Instead use the 3.d00d register for differentiation, since this register
> contains information about number of ports on the device.
>
> Fixes: 9885d016ffa9 ("net: phy: marvell10g: add separate structure for 88X3340")
> Signed-off-by: Marek Behún <kabel@...nel.org>
> Reported-by: Matteo Croce <mcroce@...ux.microsoft.com>
> ---

This one fixes, thanks!

Tested-by: Matteo Croce <mcroce@...rosoft.com>

-- 
per aspera ad upstream