netdev - Re: [PATCH net 1/1] tc-testing: Update police test cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Jul 2021 15:29:52 +0300
From:   Roi Dayan <roid@...dia.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>, <netdev@...r.kernel.org>
CC:     David Ahern <dsahern@...il.com>,
        Hangbin Liu <liuhangbin@...il.com>,
        "Paul Blakey" <paulb@...dia.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Roman Mashak <mrv@...atatu.com>,
        Baowen Zheng <baowen.zheng@...igine.com>,
        "Stephen Hemminger" <stephen@...workplumber.org>
Subject: Re: [PATCH net 1/1] tc-testing: Update police test cases



On 2021-07-08 4:05 PM, Jamal Hadi Salim wrote:
> On 2021-07-08 8:11 a.m., Roi Dayan wrote:
> 
> [..]
>>
>> no. old output doesn't have the string "index" and also output of index
>> is in hex.
>>
>> it is possible to make the old version work by allowing without index
>> and looking for either the unsigned number or hex number/
>>
>> but why do we need the old output to work? could use the "old" version
>> of the test.
> 
> I think that would work if you assume this is only going to run
> on the same kernel. But:
> In this case because output json, which provides a formally parseable
> output, then very likely someone's scripts are dependent on the old
> output out there. So things have to be backward/forward compatible.
> The new output does look better.
> Maybe one approach is to have multiple matchPattern in the tests?
> Davide?
> We will have to deal with support issues when someone says their
> script is broken.
> 
> 
> cheers,
> jamal


this patch should be ignored now.
see "police: Fix normal output back to what it was"