netdev - Re: [RFC PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jul 2021 23:27:13 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Ioana Ciornei <ioana.ciornei@....com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [RFC PATCH net-next] net: dpaa2-mac: add support for more
 ethtool 10G link modes

Hi Russell,

On Mon, 12 Jul 2021 16:47:10 +0100
Russell King <rmk+kernel@...linux.org.uk> wrote:

> Phylink documentation says:
>  * Note that the PHY may be able to transform from one connection
>  * technology to another, so, eg, don't clear 1000BaseX just
>  * because the MAC is unable to BaseX mode. This is more about
>  * clearing unsupported speeds and duplex settings. The port modes
>  * should not be cleared; phylink_set_port_modes() will help with this.

At first I thought these are points as in Markdown. Maybe remove the
asterisks from the commit message, next time :)
> 
> So add the missing 10G modes.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>
> ---
> net-next is currently closed, but I'd like to collect acks for this
> patch. Thanks.
> 
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index ae6d382d8735..543c1f202420 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
>  	case PHY_INTERFACE_MODE_10GBASER:
>  	case PHY_INTERFACE_MODE_USXGMII:
>  		phylink_set(mask, 10000baseT_Full);
> +		phylink_set(mask, 10000baseCR_Full);
> +		phylink_set(mask, 10000baseSR_Full);
> +		phylink_set(mask, 10000baseLR_Full);
> +		phylink_set(mask, 10000baseLRM_Full);
> +		phylink_set(mask, 10000baseER_Full);
>  		if (state->interface == PHY_INTERFACE_MODE_10GBASER)
>  			break;
>  		phylink_set(mask, 5000baseT_Full);

Acked-by: Marek Behún <kabel@...nel.org>