netdev - Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 12 Jul 2021 12:17:49 +0800
From:   Tonghao Zhang <xiangxia.m.yue@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for
 requeued SKBs

On Mon, Jul 12, 2021 at 11:51 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
>
> On Sat, Jul 10, 2021 at 10:00 PM <xiangxia.m.yue@...il.com> wrote:
> >
> > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> >
> > The main purpose of this tracepoint is to monitor what,
> > how many and why packets were requeued. The txq_state can
> > be used for determining the reason for packets requeued.
>
> Hmm, how can I figure out the requeue is caused by
> validate_xmit_skb_list() when it returns again==true?
> I fail to see you trace it.
This patch looks not good.
> For the other case, we can figure it out by trace_net_dev_xmit().
> So, in short, your patch looks useless.
>
> Thanks.



--
Best regards, Tonghao