netdev - Re: [PATCH] doc/af_xdp: fix bind flags option typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ8uoz1+-DX=sKDjKnqDuHAW1x7bmszpYyZQZB6cT7nJ951Nxw@mail.gmail.com>
Date:   Mon, 12 Jul 2021 10:30:56 +0200
From:   Magnus Karlsson <magnus.karlsson@...il.com>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH] doc/af_xdp: fix bind flags option typo

On Tue, Jul 6, 2021 at 7:50 AM Baruch Siach <baruch@...s.co.il> wrote:
>
> Use 'XDP_ZEROCOPY' as this options is named in if_xdp.h.
>
> Signed-off-by: Baruch Siach <baruch@...s.co.il>
> ---
>  Documentation/networking/af_xdp.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks Baruch! Sorry for the delay. Been on vacation for a week.

Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>

> diff --git a/Documentation/networking/af_xdp.rst b/Documentation/networking/af_xdp.rst
> index 42576880aa4a..60b217b436be 100644
> --- a/Documentation/networking/af_xdp.rst
> +++ b/Documentation/networking/af_xdp.rst
> @@ -243,8 +243,8 @@ Configuration Flags and Socket Options
>  These are the various configuration flags that can be used to control
>  and monitor the behavior of AF_XDP sockets.
>
> -XDP_COPY and XDP_ZERO_COPY bind flags
> --------------------------------------
> +XDP_COPY and XDP_ZEROCOPY bind flags
> +------------------------------------
>
>  When you bind to a socket, the kernel will first try to use zero-copy
>  copy. If zero-copy is not supported, it will fall back on using copy
> @@ -252,7 +252,7 @@ mode, i.e. copying all packets out to user space. But if you would
>  like to force a certain mode, you can use the following flags. If you
>  pass the XDP_COPY flag to the bind call, the kernel will force the
>  socket into copy mode. If it cannot use copy mode, the bind call will
> -fail with an error. Conversely, the XDP_ZERO_COPY flag will force the
> +fail with an error. Conversely, the XDP_ZEROCOPY flag will force the
>  socket into zero-copy mode or fail.
>
>  XDP_SHARED_UMEM bind flag
> --
> 2.30.2
>