netdev - Re: [PATCH v2 00/14] genirq: Cleanup the usage of irq_set_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFki+L=LtHFvL5+h2JtWhKMDdR5=ABzOFnvdXCDcPfGisDb-9A@mail.gmail.com>
Date:   Tue, 13 Jul 2021 09:29:37 -0400
From:   Nitesh Lal <nilal@...hat.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        netdev@...r.kernel.org, linux-api@...r.kernel.org,
        linux-pci@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Robin Murphy <robin.murphy@....com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Ingo Molnar <mingo@...nel.org>, jbrandeb@...nel.org,
        frederic@...nel.org, Juri Lelli <juri.lelli@...hat.com>,
        Alex Belits <abelits@...vell.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, rostedt@...dmis.org,
        peterz@...radead.org, davem@...emloft.net,
        akpm@...ux-foundation.org, sfr@...b.auug.org.au,
        stephen@...workplumber.org, rppt@...ux.vnet.ibm.com,
        chris.friesen@...driver.com, Marc Zyngier <maz@...nel.org>,
        Neil Horman <nhorman@...driver.com>, pjwaskiewicz@...il.com,
        Stefan Assmann <sassmann@...hat.com>,
        Tomas Henzl <thenzl@...hat.com>, kashyap.desai@...adcom.com,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        shivasharan.srikanteshwara@...adcom.com,
        sathya.prakash@...adcom.com,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        suganath-prabu.subramani@...adcom.com, james.smart@...adcom.com,
        dick.kennedy@...adcom.com, Ken Cox <jkc@...hat.com>,
        faisal.latif@...el.com, shiraz.saleem@...el.com, tariqt@...dia.com,
        Alaa Hleihel <ahleihel@...hat.com>,
        Kamal Heib <kheib@...hat.com>, borisp@...dia.com,
        saeedm@...dia.com, benve@...co.com, govind@....com,
        jassisinghbrar@...il.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        "Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        Al Stone <ahs3@...hat.com>
Subject: Re: [PATCH v2 00/14] genirq: Cleanup the usage of irq_set_affinity_hint

On Tue, Jul 13, 2021 at 1:01 AM Leon Romanovsky <leon@...nel.org> wrote:
>
> On Mon, Jul 12, 2021 at 05:27:05PM -0400, Nitesh Lal wrote:
> > Hi Leon,
> >

<snip>

> > > >
> > > > Gentle ping.
> > > > Any comments or suggestions on any of the patches included in this series?
> > >
> > > Please wait for -rc1, rebase and resend.
> > > At least i40iw was deleted during merge window.
> > >
> >
> > In -rc1 some non-trivial mlx5 changes also went in.  I was going through
> > these changes and it seems after your patch
> >
> > e4e3f24b822f: ("net/mlx5: Provide cpumask at EQ creation phase")
> >
> > we do want to control the affinity for the mlx5 interrupts from the driver.
> > Is that correct?
>
> We would like to create devices with correct affinity from the
> beginning. For this, we will introduce extension to devlink to control
> affinity that will be used prior initialization sequence.
>
> Currently, netdev users who don't want irqbalance are digging into
> their procfs, reconfigure affinity on already existing devices and
> hope for the best.
>
> This is even more cumbersome for the SIOV use case, where every physical
> NIC PCI device will/can create thousands of lightweights netdevs that will
> be forwarded to the containers later. These containers are limited to known
> CPU cores, so no reason do not limit netdev device too.
>
> The same goes for other sub-functions of that PCI device, like RDMA,
> vdpa e.t.c.
>
> > This would mean that we should use irq_set_affinity_and_hint() instead
> > of irq_update_affinity_hint().
>
> I think so.
>

Thanks, will make that change in the patch and re-send.
I will also drop your reviewed-by for the mlx5 patch so that you can
have a look at it again, please let me know if you have any
objections.

-- 
Thanks
Nitesh