netdev - Re: [EXT] [PATCH net] net: marvell: prestera: if the LAG that we're joining is under a bridge, join it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210713143500.3uzj2ccawppxox5v@skbuf>
Date:   Tue, 13 Jul 2021 14:35:01 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Taras Chornyi <tchornyi@...vell.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Vadym Kochan <vkochan@...vell.com>,
        Andrii Savka <andrii.savka@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ido Schimmel <idosch@...sch.org>
Subject: Re: [EXT] [PATCH net] net: marvell: prestera: if the LAG that we're
 joining is under a bridge, join it

Hi Taras,

On Tue, Jul 13, 2021 at 05:07:49PM +0300, Taras Chornyi wrote:
> Driver will not allow to enslave port to a bound if bond has any upper
>
> There is a check for this in prestera_netdev_port_event
>
> if (netdev_has_any_upper_dev(upper)) {
>     NL_SET_ERR_MSG_MOD(extack, "Upper device is already enslaved");
>     return -EINVAL;
> }
>
> >   	return 0;
> >   }

I didn't notice that, let me drop this patch in that case then.