netdev - Re: [PATCH v3 0/3] Fix lack of XDP TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88f91273-b498-2beb-d6a2-bf1b6b6d8472@gmail.com>
Date:   Tue, 13 Jul 2021 15:41:02 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Íñigo Huguet <ihuguet@...hat.com>,
        habetsm.xilinx@...il.com, davem@...emloft.net, kuba@...nel.org,
        ivan@...udflare.com
Cc:     ast@...nel.org, daniel@...earbox.net, hawk@...nel.org,
        john.fastabend@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 0/3] Fix lack of XDP TX queues

On 13/07/2021 15:21, Íñigo Huguet wrote:
> A change introduced in commit e26ca4b53582 ("sfc: reduce the number of
> requested xdp ev queues") created a bug in XDP_TX and XDP_REDIRECT
> because it unintentionally reduced the number of XDP TX queues, letting
> not enough queues to have one per CPU, which leaded to errors if XDP
> TX/REDIRECT was done from a high numbered CPU.
> 
> This patchs make the following changes:
> - Fix the bug mentioned above
> - Revert commit 99ba0ea616aa ("sfc: adjust efx->xdp_tx_queue_count with
>   the real number of initialized queues") which intended to fix a related
>   problem, created by mentioned bug, but it's no longer necessary
> - Add a new error log message if there are not enough resources to make
>   XDP_TX/REDIRECT work
> 
> V1 -> V2: keep the calculation of how many tx queues can handle a single
> event queue, but apply the "max. tx queues per channel" upper limit.
> V2 -> V3: WARN_ON if the number of initialized XDP TXQs differs from the
> expected.
> 
> Íñigo Huguet (3):
>   sfc: fix lack of XDP TX queues - error XDP TX failed (-22)
>   sfc: ensure correct number of XDP queues
>   sfc: add logs explaining XDP_TX/REDIRECT is not available
> 
>  drivers/net/ethernet/sfc/efx_channels.c | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)
> 

For the series:
Reviewed-by: Edward Cree <ecree.xilinx@...il.com>