netdev - Re: [PATCH v3 02/14] iavf: Use irq_update_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <163cd830-e249-9b7f-c2b3-30b04693ec95@intel.com>
Date:   Tue, 13 Jul 2021 14:51:37 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Nitesh Narayan Lal <nitesh@...hat.com>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
        <linux-api@...r.kernel.org>, <linux-pci@...r.kernel.org>,
        <tglx@...utronix.de>, <robin.murphy@....com>,
        <mtosatti@...hat.com>, <mingo@...nel.org>, <jbrandeb@...nel.org>,
        <frederic@...nel.org>, <juri.lelli@...hat.com>,
        <abelits@...vell.com>, <bhelgaas@...gle.com>,
        <rostedt@...dmis.org>, <peterz@...radead.org>,
        <davem@...emloft.net>, <akpm@...ux-foundation.org>,
        <sfr@...b.auug.org.au>, <stephen@...workplumber.org>,
        <rppt@...ux.vnet.ibm.com>, <chris.friesen@...driver.com>,
        <maz@...nel.org>, <nhorman@...driver.com>,
        <pjwaskiewicz@...il.com>, <sassmann@...hat.com>,
        <thenzl@...hat.com>, <kashyap.desai@...adcom.com>,
        <sumit.saxena@...adcom.com>,
        <shivasharan.srikanteshwara@...adcom.com>,
        <sathya.prakash@...adcom.com>, <sreekanth.reddy@...adcom.com>,
        <suganath-prabu.subramani@...adcom.com>,
        <james.smart@...adcom.com>, <dick.kennedy@...adcom.com>,
        <jkc@...hat.com>, <faisal.latif@...el.com>,
        <shiraz.saleem@...el.com>, <tariqt@...dia.com>,
        <ahleihel@...hat.com>, <kheib@...hat.com>, <borisp@...dia.com>,
        <saeedm@...dia.com>, <benve@...co.com>, <govind@....com>,
        <jassisinghbrar@...il.com>, <ajit.khaparde@...adcom.com>,
        <sriharsha.basavapatna@...adcom.com>, <somnath.kotur@...adcom.com>,
        <nilal@...hat.com>, <tatyana.e.nikolova@...el.com>,
        <mustafa.ismail@...el.com>, <ahs3@...hat.com>, <leonro@...dia.com>,
        <chandrakanth.patil@...adcom.com>
Subject: Re: [PATCH v3 02/14] iavf: Use irq_update_affinity_hint

On 7/13/2021 2:14 PM, Nitesh Narayan Lal wrote:
> The driver uses irq_set_affinity_hint() for two purposes:
>
> - To set the affinity_hint which is consumed by the userspace for
>    distributing the interrupts
>
> - To apply an affinity that it provides for the iavf interrupts
>
> The latter is done to ensure that all the interrupts are evenly spread
> across all available CPUs. However, since commit a0c9259dc4e1 ("irq/matrix:
> Spread interrupts on allocation") the spreading of interrupts is
> dynamically performed at the time of allocation. Hence, there is no need
> for the drivers to enforce their own affinity for the spreading of
> interrupts.
>
> Also, irq_set_affinity_hint() applying the provided cpumask as an affinity
> for the interrupt is an undocumented side effect. To remove this side
> effect irq_set_affinity_hint() has been marked as deprecated and new
> interfaces have been introduced. Hence, replace the irq_set_affinity_hint()
> with the new interface irq_update_affinity_hint() that only sets the
> pointer for the affinity_hint.
>
> Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com>

Thanks for this!

Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>