netdev - Re: [PATCH net] net: dsa: properly check for the bridge_leave methods in dsa_switch_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3500ae5-c062-c885-1bbe-b0685dd68776@gmail.com>
Date:   Tue, 13 Jul 2021 15:02:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net] net: dsa: properly check for the bridge_leave methods
 in dsa_switch_bridge_leave()

On 7/13/21 2:40 AM, Vladimir Oltean wrote:
> This was not caught because there is no switch driver which implements
> the .port_bridge_join but not .port_bridge_leave method, but it should
> nonetheless be fixed, as in certain conditions (driver development) it
> might lead to NULL pointer dereference.
> 
> Fixes: f66a6a69f97a ("net: dsa: permit cross-chip bridging between all trees in the system")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Too late but yes:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian