netdev - Re: [PATCH] delete useless for loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 13 Jul 2021 08:41:01 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Salah Triki <salah.triki@...il.com>
Cc:     kevin.curtis@...site.co.uk, davem@...emloft.net, kuba@...nel.org,
        stephen@...workplumber.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] delete useless for loop

Hello Salah,

On Mon, Jul 12, 2021 at 09:58:48PM +0100, Salah Triki wrote:
> Delete useless initialization of fst_card_array since the default
> initialization is NULL.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  drivers/net/wan/farsync.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/wan/farsync.c b/drivers/net/wan/farsync.c
> index b3466e084e84..0b3f561d5d5e 100644
> --- a/drivers/net/wan/farsync.c
> +++ b/drivers/net/wan/farsync.c
> @@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = {
>  static int __init
>  fst_init(void)
>  {
> -	int i;
> -
> -	for (i = 0; i < FST_MAX_CARDS; i++)
> -		fst_card_array[i] = NULL;
>  	return pci_register_driver(&fst_driver);
>  }

Looks right. I wonder if it makes sense to go even further and let
farsync.c use module_pci_driver.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)