netdev - Re: [PATCH v2] tools/runqslower: use _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAN7cG1a1sSQLuotMie44-SHyCQu5E1QCWwJxhqvVWGASaLh1PA@mail.gmail.com>
Date:   Wed, 14 Jul 2021 10:44:08 +0530
From:   Sanjay Kumar J <vjsanjay@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, kbuild-all@...ts.01.org,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] tools/runqslower: use __state instead of state

On Mon, Jul 12, 2021 at 11:12 PM kernel test robot <lkp@...el.com> wrote:
>
> Hi SanjayKumar,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on bpf-next/master]
> [also build test ERROR on vhost/linux-next ipvs/master v5.14-rc1]
> [cannot apply to bpf/master next-20210712]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
v4 version of the patch is already accepted in bpf tree
commit-id:5616e895ecc56 and also in net tree ommit:5616e895ecc56
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:    https://github.com/0day-ci/linux/commits/SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: x86_64-rhel-8.3-kselftests (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/0day-ci/linux/commit/0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review SanjayKumar-J/tools-runqslower-use-__state-instead-of-state/20210707-131703
>         git checkout 0e86dc86c0f18512dc19ba3d0b001b3f06338a0d
>         # save the attached .config to linux build tree
>         mkdir build_dir
>         make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash -C tools/testing/selftests/bpf install
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
>
> All errors (new ones prefixed by >>):
>
> >> runqslower.bpf.c:77:12: error: no member named '__state' in 'struct task_struct'; did you mean 'state'?
>            if (prev->__state == TASK_RUNNING)
>                      ^~~~~~~
>                      state
>    /tools/vmlinux.h:1096:20: note: 'state' declared here
>            volatile long int state;
>                              ^
>    1 error generated.
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org