netdev - Re: [PATCH bpf v2] bpf, sockmap, udp: sk_prot needs inuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162637200551.28238.8602014526032832150.git-patchwork-notify@kernel.org>
Date:   Thu, 15 Jul 2021 18:00:05 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     john.fastabend@...il.com, daniel@...earbox.net, lmb@...udflare.com,
        ast@...nel.org, andrii@...nel.org, xiyou.wangcong@...il.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf v2] bpf, sockmap,
 udp: sk_prot needs inuse_idx set for proc stats

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

On Wed, 14 Jul 2021 17:47:50 +0200 you wrote:
> Proc socket stats use sk_prot->inuse_idx value to record inuse sock stats.
> We currently do not set this correctly from sockmap side. The result is
> reading sock stats '/proc/net/sockstat' gives incorrect values. The
> socket counter is incremented correctly, but because we don't set the
> counter correctly when we replace sk_prot we may omit the decrement.
> 
> To get the correct inuse_idx value move the core_initcall that initializes
> the udp proto handlers to late_initcall. This way it is initialized after
> UDP has the chance to assign the inuse_idx value from the register protocol
> handler.
> 
> [...]

Here is the summary with links:
  - [bpf,v2] bpf, sockmap, udp: sk_prot needs inuse_idx set for proc stats
    https://git.kernel.org/bpf/bpf/c/54ea2f49fd94

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html