netdev - Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpXM-xhy_kVNk73235nFvU13jtN=kj7aG+ZuwcbY2V+tHQ@mail.gmail.com>
Date:   Wed, 14 Jul 2021 21:24:18 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Tonghao Zhang <xiangxia.m.yue@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [net-next 2/2] qdisc: add tracepoint qdisc:qdisc_requeue for
 requeued SKBs

On Mon, Jul 12, 2021 at 7:07 PM Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
>
> On Mon, Jul 12, 2021 at 12:17 PM Tonghao Zhang <xiangxia.m.yue@...il.com> wrote:
> >
> > On Mon, Jul 12, 2021 at 11:51 AM Cong Wang <xiyou.wangcong@...il.com> wrote:
> > >
> > > On Sat, Jul 10, 2021 at 10:00 PM <xiangxia.m.yue@...il.com> wrote:
> > > >
> > > > From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> > > >
> > > > The main purpose of this tracepoint is to monitor what,
> > > > how many and why packets were requeued. The txq_state can
> > > > be used for determining the reason for packets requeued.
> > >
> > > Hmm, how can I figure out the requeue is caused by
> > > validate_xmit_skb_list() when it returns again==true?
> Hi cong
> Consider this patch again.
> The main purpose of this tracepoint is to monitor what, how many and
> why packets were requeued.
> So should we figure out packets required by validate_xmit_skb_list or
> dev_hard_start_xmit ?
> because we may want to know what packets were requeued and how many.
>
> if we should figure out, we can add more arg for trace, right ?

Figuring out which case is important to determine the cause,
so you have to fix it to make it useful.

Thanks.