netdev - RE: [PATCH 0/2] r8152: Fix a couple of PM problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6cf8c26165a489bbf704946765ac3bd@realtek.com>
Date:   Thu, 15 Jul 2021 04:36:51 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Takashi Iwai <tiwai@...e.de>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: RE: [PATCH 0/2] r8152: Fix a couple of PM problems

> Subject: Re: [PATCH 0/2] r8152: Fix a couple of PM problems
[...]
> 
> Here is the summary with links:
>   - [1/2] r8152: Fix potential PM refcount imbalance
>     https://git.kernel.org/netdev/net/c/9c23aa51477a
>   - [2/2] r8152: Fix a deadlock by doubly PM resume
>     https://git.kernel.org/netdev/net/c/776ac63a986d

I think set_ethernet_addr() shouldn't be called at reset-resume.
The MAC address should be restored to the current one, not the
default value. Someone may change the MAC address before suspending.
And the MAC address would become the default value after reset-resume,
if set_ethernet_addr() is called.

Best Regards,
Hayes