netdev - Re: [PATCH v6 bpf-next 03/11] bpf: Introduce bpf timers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJyP0D2iFgvcCurMPF0_hQjAzqeL1wdpe8u6-ah0Oz=eA@mail.gmail.com>
Date:   Wed, 14 Jul 2021 17:43:49 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v6 bpf-next 03/11] bpf: Introduce bpf timers.

On Wed, Jul 14, 2021 at 5:00 PM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
> > +       }
> > +       /* allocate hrtimer via map_kmalloc to use memcg accounting */
> > +       t = bpf_map_kmalloc_node(map, sizeof(*t), GFP_ATOMIC, NUMA_NO_NODE);
>
> I wonder if it would make sense to use map->numa_node here to keep map
> value and timer data in the same NUMA node?
>
> > +       if (!t) {
> > +               ret = -ENOMEM;
> > +               goto out;
> > +       }
>
> [...]
>
> > +
> > +/* This function is called by map_delete/update_elem for individual element.
> > + * By ops->map_release_uref when the user space reference to a map reaches zero
> > + * and by ops->map_free when the kernel reference reaches zero.
>
> is ops->map_free part still valid?

Both good points. Will respin.