netdev - Re: [PATCH 0/6 v2] treewide: rename 'mod_init' & 'mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210716081517.GB2034@gondor.apana.org.au>
Date:   Fri, 16 Jul 2021 16:15:17 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andres Salomon <dilinger@...ued.net>,
        linux-geode@...ts.infradead.org, Matt Mackall <mpm@...enic.com>,
        linux-crypto@...r.kernel.org,
        Christian Gromm <christian.gromm@...rochip.com>,
        Krzysztof Halasa <khc@...waw.pl>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Martin Schiller <ms@....tdt.de>, linux-x25@...r.kernel.org,
        wireguard@...ts.zx2c4.com
Subject: Re: [PATCH 0/6 v2] treewide: rename 'mod_init' & 'mod_exit'
 functions to be module-specific

On Sun, Jul 11, 2021 at 03:31:42PM -0700, Randy Dunlap wrote:
> There are multiple (16) modules which use a module_init() function
> with the name 'mod_init' and a module_exit() function with the name
> 'mod_exit'. This can lead to confusion or ambiguity when reading
> crashes/oops/bugs etc. and when reading an initcall_debug log.
> 
> Example 1: (System.map file)
> 
> ffffffff83446d10 t mod_init
> ffffffff83446d18 t mod_init
> ffffffff83446d20 t mod_init
> ...
> ffffffff83454665 t mod_init
> ffffffff834548a4 t mod_init
> ffffffff83454a53 t mod_init
> ...
> ffffffff8345bd42 t mod_init
> ...
> ffffffff8345c916 t mod_init
> ffffffff8345c92a t mod_init
> ffffffff8345c93e t mod_init
> ffffffff8345c952 t mod_init
> ffffffff8345c966 t mod_init
> ...
> ffffffff834672c9 t mod_init
> 
> Example 2: (boot log when using 'initcall_debug')
> 
> [    0.252157] initcall mod_init+0x0/0x8 returned 0 after 0 usecs
> [    0.252180] initcall mod_init+0x0/0x8 returned 0 after 0 usecs
> [    0.252202] initcall mod_init+0x0/0x8 returned 0 after 0 usecs
> ...
> [    0.892907] initcall mod_init+0x0/0x23f returned -19 after 104 usecs
> [    0.913788] initcall mod_init+0x0/0x1af returned -19 after 9 usecs
> [    0.934353] initcall mod_init+0x0/0x49 returned -19 after 0 usecs
> ...
> [    1.454870] initcall mod_init+0x0/0x66 returned 0 after 72 usecs
> ...
> [    1.455527] initcall mod_init+0x0/0x14 returned 0 after 0 usecs
> [    1.455531] initcall mod_init+0x0/0x14 returned 0 after 0 usecs
> [    1.455536] initcall mod_init+0x0/0x14 returned 0 after 0 usecs
> [    1.455541] initcall mod_init+0x0/0x14 returned 0 after 0 usecs
> [    1.455545] initcall mod_init+0x0/0x52 returned 0 after 0 usecs
> ...
> [    1.588162] initcall mod_init+0x0/0xef returned 0 after 45 usecs
> 
> 
> v2: wireguard: changes per Jason
>     arm/crypto/curve25519-glue: add Russell's Acked-by
> 
> Cc: Jason A. Donenfeld <Jason@...c4.com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Andres Salomon <dilinger@...ued.net>
> Cc: linux-geode@...ts.infradead.org
> Cc: Matt Mackall <mpm@...enic.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: linux-crypto@...r.kernel.org
> Cc: Christian Gromm <christian.gromm@...rochip.com>
> Cc: Krzysztof Halasa <khc@...waw.pl>
> Cc: netdev@...r.kernel.org
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Martin Schiller <ms@....tdt.de>
> Cc: linux-x25@...r.kernel.org
> Cc: wireguard@...ts.zx2c4.com
> 
> [PATCH 1/6 v2] arm: crypto: rename 'mod_init' & 'mod_exit' functions to be module-specific
> [PATCH 2/6 v2] hw_random: rename 'mod_init' & 'mod_exit' functions to be module-specific
> [PATCH 3/6 v2] lib: crypto: rename 'mod_init' & 'mod_exit' functions to be module-specific
> [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific
> [PATCH 5/6 v2] net: hdlc: rename 'mod_init' & 'mod_exit' functions to be module-specific
> [PATCH 6/6 v2] net: wireguard: rename 'mod_init' & 'mod_exit' functions to be module-specific
> 
>  arch/arm/crypto/curve25519-glue.c  |    8 ++++----
>  drivers/char/hw_random/amd-rng.c   |    8 ++++----
>  drivers/char/hw_random/geode-rng.c |    8 ++++----
>  drivers/char/hw_random/intel-rng.c |    8 ++++----
>  drivers/char/hw_random/via-rng.c   |    8 ++++----
>  drivers/most/most_cdev.c           |    8 ++++----
>  drivers/net/wan/hdlc_cisco.c       |    8 ++++----
>  drivers/net/wan/hdlc_fr.c          |    8 ++++----
>  drivers/net/wan/hdlc_ppp.c         |    8 ++++----
>  drivers/net/wan/hdlc_raw.c         |    8 ++++----
>  drivers/net/wan/hdlc_raw_eth.c     |    8 ++++----
>  drivers/net/wan/hdlc_x25.c         |    8 ++++----
>  drivers/net/wireguard/main.c       |    8 ++++----
>  lib/crypto/blake2s.c               |    8 ++++----
>  lib/crypto/chacha20poly1305.c      |    8 ++++----
>  lib/crypto/curve25519.c            |    8 ++++----
>  16 files changed, 64 insertions(+), 64 deletions(-)

Patches 1-3 applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt