netdev - Re: [PATCH ipsec-next] xfrm: Add possibility to set the default to block if we have no policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202107181155.zntUdURz-lkp@intel.com>
Date:   Sun, 18 Jul 2021 11:26:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Antony Antony <antony.antony@...unet.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     kbuild-all@...ts.01.org,
        Christian Langrock <christian.langrock@...unet.com>,
        Antony Antony <antony.antony@...unet.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH ipsec-next] xfrm: Add possibility to set the default to
 block if we have no policy

Hi Antony,

I love your patch! Yet something to improve:

[auto build test ERROR on ipsec-next/master]

url:    https://github.com/0day-ci/linux/commits/Antony-Antony/xfrm-Add-possibility-to-set-the-default-to-block-if-we-have-no-policy/20210718-093119
base:   https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git master
config: s390-randconfig-m031-20210718 (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5aac4e97776280ef1fbe4c3d16c28833018d0985
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Antony-Antony/xfrm-Add-possibility-to-set-the-default-to-block-if-we-have-no-policy/20210718-093119
        git checkout 5aac4e97776280ef1fbe4c3d16c28833018d0985
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash net/core/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from net/core/sock.c:127:
   include/net/xfrm.h: In function 'xfrm_default_allow':
>> include/net/xfrm.h:1080:14: error: 'struct net' has no member named 'xfrm'
    1080 |  u8 def = net->xfrm.policy_default;
         |              ^~


vim +1080 include/net/xfrm.h

  1076	
  1077	static inline bool
  1078	xfrm_default_allow(struct net *net, int dir)
  1079	{
> 1080		u8 def = net->xfrm.policy_default;
  1081	
  1082		switch (dir) {
  1083		case XFRM_POLICY_IN:
  1084			return def & XFRM_POL_DEFAULT_IN ? false : true;
  1085		case XFRM_POLICY_OUT:
  1086			return def & XFRM_POL_DEFAULT_OUT ? false : true;
  1087		case XFRM_POLICY_FWD:
  1088			return def & XFRM_POL_DEFAULT_FWD ? false : true;
  1089		}
  1090		return false;
  1091	}
  1092	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (17048 bytes)