netdev - Re: DSA .port_{f,m}db_{add,del} with offloaded LAG interface on mv88e6xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Jul 2021 15:45:13 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     DENG Qingfang <dqfext@...il.com>
Cc:     netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Marek Behún <kabel@...nel.org>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Russell King - ARM Linux admin <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: DSA .port_{f,m}db_{add,del} with offloaded LAG interface on
 mv88e6xxx

Hi Qingfang,

On Mon, Jul 19, 2021 at 08:22:01PM +0800, DENG Qingfang wrote:
> Hi,
> 
> What happens if a FDB entry is added manually to an offloaded LAG
> interface? Does DSA core simply call .port_fdb_add with the member
> ports in the LAG?
> 
> I'm asking because there is a trunk field in struct
> mv88e6xxx_atu_entry, when it is true, the portvec is actually the
> trunk ID.
> As the current implementation (mv88e6xxx_port_db_load_purge) does not
> use this field, it probably won't work.
> 
> Regards,
> Qingfang

This is not supported at the moment.
Coincidentally or not, I am currently working on refactoring the DSA
handler for SWITCHDEV_FDB_ADD_TO_DEVICE to remove some of the technical
debt (in particular, local FDB entries pointing towards the bridge do
not work in all situations when combined with FDB replays). One of the
extra features of the new implementation will be a new .lag_fdb_add()
method in struct dsa_switch_ops.