netdev - Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS PTP pin functions on 82580/i354/i350

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Jul 2021 17:01:11 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ruud Bos <ruud.bos@...world.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS PTP
 pin functions on 82580/i354/i350

On Mon, Jul 19, 2021 at 02:45:06PM +0000, Ruud Bos wrote:
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Monday, July 19, 2021 16:29
> > To: Ruud Bos <ruud.bos@...world.com>
> > Cc: netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org;
> > jesse.brandeburg@...el.com; anthony.l.nguyen@...el.com; Richard Cochran
> > <richardcochran@...il.com>
> > Subject: Re: [PATCH net-next 0/4 resend] igb: support PEROUT and EXTTS
> > PTP pin functions on 82580/i354/i350
> >
> > On Mon, Jul 19, 2021 at 11:33:11AM +0000, Ruud Bos wrote:
> > > The igb driver provides support for PEROUT and EXTTS pin functions that
> > > allow adapter external use of timing signals. At Hottinger Bruel & Kjaer we
> > > are using the PEROUT function to feed a PTP corrected 1pps signal into an
> > > FPGA as cross system synchronized time source.
> >
> > Please always Cc: The PTP maintainer for PTP patches.
> > Richard Cochran <richardcochran@...il.com>
> 
> Thanks, will do that!
> Do I need to resend again?

It is probably a good idea to resend. It will make it easier for
Richard if the patches are in his mailbox.

> This is my first ever contribution, so it's all kinda new to me,
> sorry :-)

Cc: Richard is not so obvious as it should be, since
./scripts/get_maintainers.pl would not of suggested it, since you are
not modify the PTP core. It takes a bit of experience to know this.

This is the second time something like this has happened recently for
Intel Ethernet drivers. The other case was making use of the LED
subsystem from within an Ethernet driver, and the LED subsystem
maintainers were not Cc:. It would be good if the Intel Maintainers
actually took notice of this, they have the experience to know better.

I noticed your patches are not threaded. Did you use git send-email?
It normally does thread a patchset. The threading keeps the patchset
together, which can be important for some of the bots which scoop up
patches in emails and run tests on them. Please see if you can fix
that in the resend.

     Andrew