netdev - Re: [PATCH net] net/tcp_fastopen: remove obsolete extern

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEA6p_Dr9Vgber447H5aHhVxvfYmPRYrQAOhzZcnQ_+6T8nuJQ@mail.gmail.com>
Date:   Mon, 19 Jul 2021 08:43:36 -0700
From:   Wei Wang <weiwan@...gle.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Haishuang Yan <yanhaishuang@...s.chinamobile.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH net] net/tcp_fastopen: remove obsolete extern

On Mon, Jul 19, 2021 at 2:20 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
> From: Eric Dumazet <edumazet@...gle.com>
>
> After cited commit, sysctl_tcp_fastopen_blackhole_timeout is no longer
> a global variable.
>
> Fixes: 3733be14a32b ("ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Haishuang Yan <yanhaishuang@...s.chinamobile.com>
> Cc: Wei Wang <weiwan@...gle.com>
> Cc: Yuchung Cheng <ycheng@...gle.com>
> Cc: Neal Cardwell <ncardwell@...gle.com>
> ---

Acked-by: Wei Wang <weiwan@...gle.com>

>  include/net/tcp.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/net/tcp.h b/include/net/tcp.h
> index 17df9b047ee46dabed8797246f99e1a2fd39c243..784d5c3ef1c5be0b54194711ff7f306d271d95c3 100644
> --- a/include/net/tcp.h
> +++ b/include/net/tcp.h
> @@ -1709,7 +1709,6 @@ struct tcp_fastopen_context {
>         struct rcu_head rcu;
>  };
>
> -extern unsigned int sysctl_tcp_fastopen_blackhole_timeout;
>  void tcp_fastopen_active_disable(struct sock *sk);
>  bool tcp_fastopen_active_should_disable(struct sock *sk);
>  void tcp_fastopen_active_disable_ofo_check(struct sock *sk);
> --
> 2.32.0.402.g57bb445576-goog
>