netdev - Re: [PATCH v6 1/2] net: phy: add API to read 802.3-c45 IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560828fa-928a-7253-d875-7a137257445c@hauke-m.de>
Date:   Mon, 19 Jul 2021 20:30:41 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Xu Liang <lxu@...linear.com>, andrew@...n.ch, hkallweit1@...il.com,
        netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        vee.khee.wong@...ux.intel.com
Cc:     linux@...linux.org.uk, hmehrtens@...linear.com,
        tmohren@...linear.com, mohammad.athari.ismail@...el.com
Subject: Re: [PATCH v6 1/2] net: phy: add API to read 802.3-c45 IDs

On 7/19/21 7:32 AM, Xu Liang wrote:
> Add API to read 802.3-c45 IDs so that C22/C45 mixed device can use
> C45 APIs without failing ID checks.
> 
> Signed-off-by: Xu Liang <lxu@...linear.com>

Acked-by: Hauke Mehrtens <hmehrtens@...linear.com>

> ---
> v5 changes:
>   Fix incorrect prototype name in comment.
> 
>   drivers/net/phy/phy_device.c | 14 ++++++++++++++
>   include/linux/phy.h          |  1 +
>   2 files changed, 15 insertions(+)
> 
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 5d5f9a9ee768..107aa6d7bc6b 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -968,6 +968,20 @@ void phy_device_remove(struct phy_device *phydev)
>   }
>   EXPORT_SYMBOL(phy_device_remove);
>   
> +/**
> + * phy_get_c45_ids - Read 802.3-c45 IDs for phy device.
> + * @phydev: phy_device structure to read 802.3-c45 IDs
> + *
> + * Returns zero on success, %-EIO on bus access error, or %-ENODEV if
> + * the "devices in package" is invalid.
> + */
> +int phy_get_c45_ids(struct phy_device *phydev)
> +{
> +	return get_phy_c45_ids(phydev->mdio.bus, phydev->mdio.addr,
> +			       &phydev->c45_ids);
> +}
> +EXPORT_SYMBOL(phy_get_c45_ids);
> +
>   /**
>    * phy_find_first - finds the first PHY device on the bus
>    * @bus: the target MII bus
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 3b80dc3ed68b..736e1d1a47c4 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -1431,6 +1431,7 @@ static inline int phy_device_register(struct phy_device *phy)
>   static inline void phy_device_free(struct phy_device *phydev) { }
>   #endif /* CONFIG_PHYLIB */
>   void phy_device_remove(struct phy_device *phydev);
> +int phy_get_c45_ids(struct phy_device *phydev);
>   int phy_init_hw(struct phy_device *phydev);
>   int phy_suspend(struct phy_device *phydev);
>   int phy_resume(struct phy_device *phydev);
>