netdev - Re: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <787d71b4cb5174bda5a35d5ea44777d994b85e59.camel@microchip.com>
Date:   Mon, 19 Jul 2021 06:45:35 +0000
From:   <Christian.Gromm@...rochip.com>
To:     <rdunlap@...radead.org>, <linux-kernel@...r.kernel.org>
CC:     <linux-x25@...r.kernel.org>, <ms@....tdt.de>, <mpm@...enic.com>,
        <linux@...linux.org.uk>, <wireguard@...ts.zx2c4.com>,
        <Jason@...c4.com>, <khc@...waw.pl>, <kuba@...nel.org>,
        <dilinger@...ued.net>, <linux-arm-kernel@...ts.infradead.org>,
        <gregkh@...uxfoundation.org>, <netdev@...r.kernel.org>,
        <davem@...emloft.net>, <arnd@...db.de>,
        <herbert@...dor.apana.org.au>, <linux-geode@...ts.infradead.org>,
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit'
 functions to be module-specific


On Sun, 2021-07-11 at 15:31 -0700, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Rename module_init & module_exit functions that are named
> "mod_init" and "mod_exit" so that they are unique in both the
> System.map file and in initcall_debug output instead of showing
> up as almost anonymous "mod_init".
> 
> This is helpful for debugging and in determining how long certain
> module_init calls take to execute.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Christian Gromm <christian.gromm@...rochip.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> v2: no change
> 
>  drivers/most/most_cdev.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> --- linux-next-20210708.orig/drivers/most/most_cdev.c
> +++ linux-next-20210708/drivers/most/most_cdev.c
> @@ -486,7 +486,7 @@ static struct cdev_component comp = {
>         },
>  };
> 
> -static int __init mod_init(void)
> +static int __init most_cdev_init(void)
>  {
>         int err;
> 
> @@ -518,7 +518,7 @@ dest_ida:
>         return err;
>  }
> 
> -static void __exit mod_exit(void)
> +static void __exit most_cdev_exit(void)
>  {
>         struct comp_channel *c, *tmp;
> 
> @@ -534,8 +534,8 @@ static void __exit mod_exit(void)
>         class_destroy(comp.class);
>  }
> 
> -module_init(mod_init);
> -module_exit(mod_exit);
> +module_init(most_cdev_init);
> +module_exit(most_cdev_exit);
>  MODULE_AUTHOR("Christian Gromm <christian.gromm@...rochip.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("character device component for mostcore");

Acked-by: Christian Gromm (christian.gromm@...rochip.com)