lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Jul 2021 13:18:02 +0000 From: Liang Xu <lxu@...linear.com> To: Andrew Lunn <andrew@...n.ch> CC: "hkallweit1@...il.com" <hkallweit1@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org" <kuba@...nel.org>, "vee.khee.wong@...ux.intel.com" <vee.khee.wong@...ux.intel.com>, "linux@...linux.org.uk" <linux@...linux.org.uk>, Hauke Mehrtens <hmehrtens@...linear.com>, Thomas Mohren <tmohren@...linear.com>, "mohammad.athari.ismail@...el.com" <mohammad.athari.ismail@...el.com> Subject: Re: [PATCH v6 2/2] net: phy: add Maxlinear GPY115/21x/24x driver On 20/7/2021 9:02 pm, Andrew Lunn wrote: > This email was sent from outside of MaxLinear. > > > On Tue, Jul 20, 2021 at 03:35:17AM +0000, Liang Xu wrote: >> On 20/7/2021 4:48 am, Andrew Lunn wrote: >>> This email was sent from outside of MaxLinear. >>> >>> >>>> +/* PHY ID */ >>>> +#define PHY_ID_GPYx15B_MASK 0xFFFFFFFC >>>> +#define PHY_ID_GPY21xB_MASK 0xFFFFFFF9 >>> That is an odd mask. Is that really correct? >>> >>> Andrew >>> >> Hi Andrew, >> >> >> Yes, this is correct and has been tested. >> >> It's special because of a PHY ID scheme change during manufacturing. > O.K. It is just a really odd mask. And putting the revision in the > middle, not at the end? And none of the IDs have bit 0 set. It just > all adds up to it looking wrong. So i had to ask. > > Andrew > Understood. Here are the revisions already in the market (shipped): 1. GPY211B - 67C9DE08, 67C9DE0A 2. GPY212B - 67C9DE09, 67C9DE0B
Powered by blists - more mailing lists