netdev - Re: [PATCH net-next v14 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dleftjlf61nlgi.fsf%l.stelmach@samsung.com>
Date:   Tue, 20 Jul 2021 15:50:21 +0200
From:   Lukasz Stelmach <l.stelmach@...sung.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH net-next v14 3/3] net: ax88796c: ASIX AX88796C SPI
 Ethernet Adapter Driver

It was <2021-07-20 wto 12:36>, when Jakub Kicinski wrote:
> On Mon, 19 Jul 2021 21:28:52 +0200, Łukasz Stelmach wrote:
>> +	ax_local->stats =
>> +		devm_netdev_alloc_pcpu_stats(&spi->dev,
>> +					     struct ax88796c_pcpu_stats);
>> +	if (!ax_local->stats)
>> +		return -ENOMEM;
>> +	u64_stats_init(&ax_local->stats->syncp);
>
> ../drivers/net/ethernet/asix/ax88796c_main.c:971:33: warning: incorrect type in argument 1 (different address spaces)
> ../drivers/net/ethernet/asix/ax88796c_main.c:971:33:    expected struct u64_stats_sync *syncp
> ../drivers/net/ethernet/asix/ax88796c_main.c:971:33:    got struct u64_stats_sync [noderef] __percpu *
>

Fixed, thanks.

Apparently separate u64_stats_init() is not necessary as
netdev_alloc_pcpu_stats() invokes it for_each_possible_cpu.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Download attachment "signature.asc" of type "application/pgp-signature" (488 bytes)