netdev - Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPbU59Kmpk0NvlQH@lunn.ch>
Date:   Tue, 20 Jul 2021 15:51:35 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Ioana Ciornei <ioana.ciornei@....com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool
 10G link modes

On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote:
> Phylink documentation says:
>   Note that the PHY may be able to transform from one connection
>   technology to another, so, eg, don't clear 1000BaseX just
>   because the MAC is unable to BaseX mode. This is more about
>   clearing unsupported speeds and duplex settings. The port modes
>   should not be cleared; phylink_set_port_modes() will help with this.
> 
> So add the missing 10G modes.

Hi Russell

Would a phylink_set_10g(mask) helper make sense? As you say, it is
about the speed, not the individual modes.

      Andrew