netdev - Re: [PATCH RFC net-next] net: phy: marvell10g: add downshift tunable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210720170424.07cba755@dellmb>
Date:   Tue, 20 Jul 2021 17:04:24 +0200
From:   Marek Behún <kabel@...nel.org>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH RFC net-next] net: phy: marvell10g: add downshift
 tunable support

Hi Russell,

On Tue, 20 Jul 2021 14:38:20 +0100
Russell King <rmk+kernel@...linux.org.uk> wrote:

> Add support for the downshift tunable for the Marvell 88x3310 PHY.
> Downshift is only usable with firmware 0.3.5.0 and later.

mv3310_{g,s}et_features are also used for 88E211x, but there is no such
register in the documentation for these PHYs. (Also firmware versions on
those are different, the newest is 8.3.0.0, but thats not important.)
My solution would be to rename the current methods prefix to mv211x_ and
and add new mv3310_{g,s}et_tunable methods.

Marek