lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Jul 2021 10:17:45 -0700 From: Nathan Chancellor <nathan@...nel.org> To: Colin King <colin.king@...onical.com>, Chas Williams <3chas3@...il.com>, Nick Desaulniers <ndesaulniers@...gle.com>, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, clang-built-linux@...glegroups.com Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] atm: idt77252: clean up trigraph warning on ??) string On 7/20/2021 5:48 AM, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > The character sequence ??) is a trigraph and causes the following > clang warning: > > drivers/atm/idt77252.c:3544:35: warning: trigraph ignored [-Wtrigraphs] > > Clean this by replacing it with single ?. > > Signed-off-by: Colin Ian King <colin.king@...onical.com> This looks good to me but I am curious how you say this warning in the first place since the main Makefile disables this unconditionally. Did you just pass -Wtrigraphs via KCFLAGS or something similar? Reviewed-by: Nathan Chancellor <nathan@...nel.org> > --- > drivers/atm/idt77252.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c > index 9e4bd751db79..81ce81a75fc6 100644 > --- a/drivers/atm/idt77252.c > +++ b/drivers/atm/idt77252.c > @@ -3536,7 +3536,7 @@ static int idt77252_preset(struct idt77252_dev *card) > return -1; > } > if (!(pci_command & PCI_COMMAND_IO)) { > - printk("%s: PCI_COMMAND: %04x (???)\n", > + printk("%s: PCI_COMMAND: %04x (?)\n", > card->name, pci_command); > deinit_card(card); > return (-1); >
Powered by blists - more mailing lists