netdev - Re: [PATCH RFC net-next] net: phy: marvell10g: add downshift tunable support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210720195021.62feacb4@dellmb>
Date:   Tue, 20 Jul 2021 19:50:21 +0200
From:   Marek Behún <kabel@...nel.org>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH RFC net-next] net: phy: marvell10g: add downshift
 tunable support

On Tue, 20 Jul 2021 18:39:41 +0100
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> I was intending to leave the firmware version check where it was and
> just add a flag to say "this has downshift". The older firmwares on
> 3310 are basically buggy - they do downshift but only from 1G to 100M,
> they fail to go to 10M.

So we have two options

* do the firmware version comparison at the position where the given
  feature is being configured

* do the firmware version comparison in probe method and set specific
  flags for all features

The second option is better if different PHYs have differnet system of
versioning, but this can potentially lead to many different flags.

I'll leave this decision to you.

> > BTW would you agree with a patch renaming the mv3310_ prefixes to
> > mv10g_ for all functions that are generic to both mv3310_ and
> > mv2110_?
> > I was thinking about such a thing because it has become rather
> > confusing.  
> 
> I've been thinking the same thing actually.

OK I will send a patch then once your downshift patch is applied.

Marek