netdev - Re: [PATCH RFC] net: hns3: add a module parameter wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPaQ0qW+uIToEM6c@unreal>
Date:   Tue, 20 Jul 2021 12:01:06 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Yufeng Mo <moyufeng@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        shenjian15@...wei.com, lipeng321@...wei.com,
        yisen.zhuang@...wei.com, linyunsheng@...wei.com,
        zhangjiaran@...wei.com, huangguangbin2@...wei.com,
        chenhao288@...ilicon.com, salil.mehta@...wei.com,
        linuxarm@...wei.com, linuxarm@...neuler.org
Subject: Re: [PATCH RFC] net: hns3: add a module parameter wq_unbound

On Tue, Jul 20, 2021 at 04:34:57PM +0800, Yufeng Mo wrote:
> To meet the requirements of different scenarios, the WQ_UNBOUND
> flag of the workqueue is transferred as a module parameter. Users
> can flexibly configure the usage mode as required.
> 
> Signed-off-by: Yufeng Mo <moyufeng@...wei.com>
> ---
>  drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c   | 10 +++++++++-
>  drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 10 +++++++++-
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> index dd3354a..9816592 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> @@ -76,6 +76,10 @@ static struct hnae3_ae_algo ae_algo;
>  
>  static struct workqueue_struct *hclge_wq;
>  
> +static unsigned int wq_unbound;
> +module_param(wq_unbound, uint, 0400);
> +MODULE_PARM_DESC(wq_unbound, "Specifies WQ_UNBOUND flag for the workqueue, non-zero value takes effect");

Nice, but no. We don't like module parameters for such a basic thing.
Somehow all other NIC drivers in the world works without it and hns3
will success too.

Thanks

> +
>  static const struct pci_device_id ae_algo_pci_tbl[] = {
>  	{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_GE), 0},
>  	{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_25GE), 0},
> @@ -12936,7 +12940,11 @@ static int hclge_init(void)
>  {
>  	pr_info("%s is initializing\n", HCLGE_NAME);
>  
> -	hclge_wq = alloc_workqueue("%s", 0, 0, HCLGE_NAME);
> +	if (wq_unbound)
> +		hclge_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, HCLGE_NAME);
> +	else
> +		hclge_wq = alloc_workqueue("%s", 0, 0, HCLGE_NAME);
> +
>  	if (!hclge_wq) {
>  		pr_err("%s: failed to create workqueue\n", HCLGE_NAME);
>  		return -ENOMEM;
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> index 52eaf82..85f6772 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
> @@ -21,6 +21,10 @@ static struct hnae3_ae_algo ae_algovf;
>  
>  static struct workqueue_struct *hclgevf_wq;
>  
> +static unsigned int wq_unbound;
> +module_param(wq_unbound, uint, 0400);
> +MODULE_PARM_DESC(wq_unbound, "Specifies WQ_UNBOUND flag for the workqueue, non-zero value takes effect");
> +
>  static const struct pci_device_id ae_algovf_pci_tbl[] = {
>  	{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_VF), 0},
>  	{PCI_VDEVICE(HUAWEI, HNAE3_DEV_ID_RDMA_DCB_PFC_VF),
> @@ -3855,7 +3859,11 @@ static int hclgevf_init(void)
>  {
>  	pr_info("%s is initializing\n", HCLGEVF_NAME);
>  
> -	hclgevf_wq = alloc_workqueue("%s", 0, 0, HCLGEVF_NAME);
> +	if (wq_unbound)
> +		hclgevf_wq = alloc_workqueue("%s", WQ_UNBOUND, 0, HCLGEVF_NAME);
> +	else
> +		hclgevf_wq = alloc_workqueue("%s", 0, 0, HCLGEVF_NAME);
> +
>  	if (!hclgevf_wq) {
>  		pr_err("%s: failed to create workqueue\n", HCLGEVF_NAME);
>  		return -ENOMEM;
> -- 
> 2.8.1
>