netdev - Re: [PATCH] NIU: fix missing revert of return and fix the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210721.084759.550228860951288308.davem@davemloft.net>
Date:   Wed, 21 Jul 2021 08:47:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     paul@...ma.org
Cc:     gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        stable@...r.kernel.org, kjlu@....edu
Subject: Re: [PATCH] NIU: fix missing revert of return and fix the driver

From: Paul Jakma <paul@...ma.org>
Date: Tue, 20 Jul 2021 21:10:37 +0100 (BST)

> The revert of commit 26fd962 missed out on reverting an incorrect
> change to a return value. The niu_pci_vpd_scan_props(..) == 1 case
> appears to be a normal path - treating it as an error and return
> -EINVAL was breaking VPD_SCAN and causing the driver to fail to load.
> 
> Fix it, so my Neptune card works again.
> 
> Cc: Kangjie Lu <kjlu@....edu>
> Cc: Shannon Nelson <shannon.lee.nelson@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Fixes: 7930742d ('Revert "niu: fix missing checks of
> niu_pci_eeprom_read"')
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: Paul Jakma <paul@...ma.org>
> ---

This does not apply to the current networking GIT tree, what tree is it against?

Thank you.