netdev - Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPhOcwiEUW+cchJ1@hovoldconsulting.com>
Date:   Wed, 21 Jul 2021 18:42:27 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Dongliang Mu <mudongliangabcd@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Oliver Neukum <oneukum@...e.com>,
        Anirudh Rayabharam <mail@...rudhrb.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Rustam Kovhaev <rkovhaev@...il.com>,
        Zheng Yongjun <zhengyongjun3@...wei.com>,
        Emil Renner Berthing <kernel@...il.dk>,
        syzbot+44d53c7255bb1aea22d2@...kaller.appspotmail.com,
        YueHaibing <yuehaibing@...wei.com>, linux-usb@...r.kernel.org,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] usb: hso: fix error handling code of
 hso_create_net_device

On Wed, Jul 21, 2021 at 04:34:56PM +0200, Johan Hovold wrote:
> On Wed, Jul 21, 2021 at 04:17:01PM +0800, Dongliang Mu wrote:
> > On Wed, Jul 21, 2021 at 3:36 PM Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote:
> > > > The current error handling code of hso_create_net_device is
> > > > hso_free_net_device, no matter which errors lead to. For example,
> > > > WARNING in hso_free_net_device [1].
> > > >
> > > > Fix this by refactoring the error handling code of
> > > > hso_create_net_device by handling different errors by different code.
> > > >
> > > > [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe
> > > >
> > > > Reported-by: syzbot+44d53c7255bb1aea22d2@...kaller.appspotmail.com
> > > > Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe")
> > > > Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> > > > ---
> > > > v1->v2: change labels according to the comment of Dan Carpenter
> > > > v2->v3: change the style of error handling labels
> > > >  drivers/net/usb/hso.c | 33 +++++++++++++++++++++++----------
> > > >  1 file changed, 23 insertions(+), 10 deletions(-)
> > >
> > > Please resend the whole series, not just one patch of the series.
> > > Otherwise it makes it impossible to determine what patch from what
> > > series should be applied in what order.
> > >
> > 
> > Done. Please review the resend v3 patches.
> > 
> > > All of these are now dropped from my queue, please fix up and resend.
> 
> A version of this patch has already been applied to net-next.

That was apparently net (not net-next).

> No idea which version that was or why the second patch hasn't been
> applied yet.
> 
> Dongliang, if you're resending something here it should first be rebased
> on linux-next (net-next).

And the resend of v3 of both patches has now also been applied to
net-next.

Hopefully there are no conflicts between v2 and v3 but we'll see soon.

Johan