netdev - Re: [PATCH net-next v5 2/6] ipv6: ioam: Data plane support for Pre-allocated Trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <144299238.24382358.1626887267507.JavaMail.zimbra@uliege.be>
Date:   Wed, 21 Jul 2021 19:07:47 +0200 (CEST)
From:   Justin Iurman <justin.iurman@...ege.be>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, tom@...bertland.com
Subject: Re: [PATCH net-next v5 2/6] ipv6: ioam: Data plane support for
 Pre-allocated Trace

>>  static bool ipv6_hop_jumbo(struct sk_buff *skb, int optoff)
>> @@ -999,6 +1056,10 @@ static const struct tlvtype_proc tlvprochopopt_lst[] = {
>>  		.type	= IPV6_TLV_ROUTERALERT,
>>  		.func	= ipv6_hop_ra,
>>  	},
>> +	{
>> +		.type	= IPV6_TLV_IOAM,
>> +		.func	= ipv6_hop_ioam,
>> +	},
> 
> It is a bit strange to put a not-yet used option in the midle of the table,
> before TLV_JUMBO (that some of us use already...)

Eric,

It's been a long time since I added it in the list, it's indeed an oversight. I'll move it down.

>>  	{
>>  		.type	= IPV6_TLV_JUMBO,
> >  		.func	= ipv6_hop_jumbo,