netdev - Re: [PATCH net-next 09/12] igc: Remove _I_PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jul 2021 21:02:13 +0300
From:   Sasha Neftin <sasha.neftin@...el.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <vitaly.lifshits@...el.com>,
        Dvora Fuxbrumer <dvorax.fuxbrumer@...ux.intel.com>,
        "Neftin, Sasha" <sasha.neftin@...el.com>
Subject: Re: [PATCH net-next 09/12] igc: Remove _I_PHY_ID checking

On 7/21/2021 17:50, Andrew Lunn wrote:
> On Tue, Jul 20, 2021 at 04:20:58PM -0700, Tony Nguyen wrote:
>> From: Sasha Neftin <sasha.neftin@...el.com>
>>
>> i225 devices have only one PHY vendor. There is no point checking
>> _I_PHY_ID during the link establishment and auto-negotiation process.
>> This patch comes to clean up these pointless checkings.
> 
> I don't know this hardware....
> 
> Is the PHY integrated into the MAC? Or is it external?
i225 controller offers a fully-integrated Media Access Control
(MAC) and Physical Layer (PHY) port.
Both components (MAC and PHY) supports 2.5G
> 
> For the ixgbe, the InPhi CS4227 is now owned by Marvell, and it is
> very difficult to get any information from them. At some point, it
> would be nice to have a second source, maybe a Microchip PHY. The bits
> of code you are removing make it easier to see where changes would be
> needed to add support for a second PHY. Why would you want to limit it
> to just one vendor?
Not like that i210 devices. There is only one PHY ID/type for this 
product. Only one port. No fiber, no SFP - only copper. No option for a 
second PHY.
> 
>         Andrew
> 
Sasha Neftin