netdev - Re: [PATCH v5 2/4] net: socket: rework SIOC?IFMAP ioctls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210721072847.GB11257@lst.de>
Date:   Wed, 21 Jul 2021 09:28:47 +0200
From:   Christoph Hellwig <hch@....de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     netdev@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v5 2/4] net: socket: rework SIOC?IFMAP ioctls

> +static int dev_getifmap(struct net_device *dev, struct ifreq *ifr)
> +{
> +	struct ifmap *ifmap = &ifr->ifr_map;
> +	struct compat_ifmap *cifmap = (struct compat_ifmap *)&ifr->ifr_map;
> +
> +	if (in_compat_syscall()) {

Any reason that the cifmap declaration is outside this conditional?

> +static int dev_setifmap(struct net_device *dev, struct ifreq *ifr)
> +{
> +	struct compat_ifmap *cifmap = (struct compat_ifmap *)&ifr->ifr_map;
> +
> +	if (!dev->netdev_ops->ndo_set_config)
> +		return -EOPNOTSUPP;
> +
> +	if (in_compat_syscall()) {

Same here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>